micheleandClaude Sonnet 5
7e2711fa27
Bumps ADDR_WIDTH's default from 22 to 23 bits across every RTL module (neuron_memory, layer_sequencer, spi_engine, spi_neuron_top, mem_arbiter, int8_memory_access, memory_interface, psram_controller, memory_model) and every testbench that mirrors it, so the system's byte-address space reaches the full 8 MiB the recommended PSRAM part (ISSI IS66WVE4M16EBLL-70BLI, docs/FPGA-Neural-Hardware-Design.md §3) actually provides -- previously only 4 MiB (half the chip) was reachable, since int8_memory_access.v's byte->word address shift (addr >> 1) turned the old 22-bit byte address into only 21 real word bits, one short of the chip's real 22-bit word address (A0-A21). At 23 bits, that same shift lands exactly on all 22 chip address lines, so the whole part is usable now instead of deferred to a future widening. Also fixes a stray 22'd11-sized literal in layer_sequencer.v's descriptor-table address increment (numerically already safe via Verilog's zero-extension, but now correctly unsized so it always matches ADDR_WIDTH instead of silently assuming 22). Updated docs/FPGA-NeuralNetwork-Engine.md's SPI protocol address-field note (23 bits, top 1 reserved bit instead of 2) and docs/FPGA-Neural-Hardware-Design.md's PSRAM section (the "chip has one spare address line" framing is gone now that all 22 are wired and used). Full regression (all 11 ADDR_WIDTH-touching testbenches, plus a Yosys elaboration check of spi_neuron_top with the new default and no override) passes clean. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WQV3vS9TXaGDJ5cRfnfidt
94 lines
2.4 KiB
Verilog
94 lines
2.4 KiB
Verilog
module memory_interface #(
|
|
parameter ADDR_WIDTH = 23,
|
|
parameter DATA_WIDTH = 16
|
|
)(
|
|
input wire clk,
|
|
input wire rst,
|
|
|
|
input wire req,
|
|
input wire wr,
|
|
input wire [ADDR_WIDTH-1:0] addr,
|
|
input wire [DATA_WIDTH-1:0] wdata,
|
|
input wire lb_n,
|
|
input wire ub_n,
|
|
|
|
output reg [DATA_WIDTH-1:0] rdata,
|
|
output reg ready,
|
|
|
|
output reg mem_req,
|
|
output reg mem_wr,
|
|
output reg [ADDR_WIDTH-1:0] mem_addr,
|
|
output reg [DATA_WIDTH-1:0] mem_wdata,
|
|
output reg mem_lb_n,
|
|
output reg mem_ub_n,
|
|
|
|
input wire [DATA_WIDTH-1:0] mem_rdata,
|
|
input wire mem_ready
|
|
);
|
|
localparam STATE_IDLE = 2'd0;
|
|
localparam STATE_WAIT = 2'd1;
|
|
|
|
reg [1:0] state;
|
|
|
|
always @(posedge clk) begin
|
|
if (rst) begin
|
|
state <= STATE_IDLE;
|
|
|
|
rdata <= {DATA_WIDTH{1'b0}};
|
|
ready <= 1'b0;
|
|
|
|
mem_lb_n <= 1'b1;
|
|
mem_ub_n <= 1'b1;
|
|
|
|
mem_req <= 1'b0;
|
|
mem_wr <= 1'b0;
|
|
mem_addr <= {ADDR_WIDTH{1'b0}};
|
|
mem_wdata <= {DATA_WIDTH{1'b0}};
|
|
|
|
end else begin
|
|
|
|
// Default: pulses
|
|
ready <= 1'b0;
|
|
mem_req <= 1'b0;
|
|
|
|
case (state)
|
|
|
|
STATE_IDLE: begin
|
|
if (req) begin
|
|
|
|
// Latch transaction
|
|
mem_wr <= wr;
|
|
mem_addr <= addr;
|
|
mem_wdata <= wdata;
|
|
mem_lb_n <= lb_n;
|
|
mem_ub_n <= ub_n;
|
|
// Issue exactly one-cycle request
|
|
mem_req <= 1'b1;
|
|
|
|
state <= STATE_WAIT;
|
|
end
|
|
end
|
|
|
|
STATE_WAIT: begin
|
|
|
|
// Wait for memory completion
|
|
if (mem_ready) begin
|
|
|
|
if (!mem_wr)
|
|
rdata <= mem_rdata;
|
|
|
|
ready <= 1'b1;
|
|
|
|
state <= STATE_IDLE;
|
|
end
|
|
end
|
|
|
|
default: begin
|
|
state <= STATE_IDLE;
|
|
end
|
|
|
|
endcase
|
|
end
|
|
end
|
|
|
|
endmodule |