Warn when same_layer decoupling is on the opposite copper.

PS-PLC-003 uses the same_layer flag plus F/B layers from the PCB. A via in the courtyard is enough; an unset flag skips.

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
2026-09-10 23:45:59 +02:00
co-authored by Cursor
parent 0fafbbbb06
commit ba2a5c1b29
3 changed files with 164 additions and 5 deletions
+91 -4
View File
@@ -1,8 +1,7 @@
"""G2 placement vs simple_project — no invented millimetre boards.
Favor: real U1 + caps on +3V3 exist; eval stays 3 keys.
Against: no .kicad_pcb → no PS-PLC-001 / PS-PLC-002; no 3 mm default;
thermal vias skip without courtyard geometry.
Favor: real U1 + C4 on +3V3; same_layer True + opposite copper → PS-PLC-003.
Against: no PCB; same copper; same_layer unset; via in courtyard.
"""
from __future__ import annotations
@@ -10,7 +9,15 @@ from __future__ import annotations
from pathlib import Path
from backend.pinscopex.eval_report import eval_simple_project
from backend.pinscopex.models import DesignGraph
from backend.pinscopex.models import (
ComponentConstraints,
DesignGraph,
LayoutFootprint,
LayoutGraph,
LayoutPad,
LayoutVia,
Pin,
)
from backend.pinscopex.placement_check import _in_poly, check_placement
SIMPLE = Path(__file__).resolve().parents[1] / "simple_project"
@@ -53,3 +60,83 @@ def test_via_count_is_calculated_from_courtyard_and_min_parameter():
assert inside < min_via_count
assert _in_poly(0.5, 0.5, courtyard) is True
assert _in_poly(10.0, 10.0, courtyard) is False
def _ldo_cons(*, same_layer: bool | None):
mpn = "SPX3819M5-L-3-3/TR"
rule: dict = {"kind": "decoupling_proximity", "pin": "5"}
if same_layer is not None:
rule["same_layer"] = same_layer
return {
mpn: ComponentConstraints(
mpn=mpn,
pintable=[Pin(number=5, name="+3V3")],
absolute_maximum_ratings=[],
rules=[],
layout_rules=[rule],
)
}
def _u1_c4_layout(*, ic_layer: str, cap_layer: str, via_xy=None, courtyard=None):
vias = []
if via_xy is not None:
vias = [LayoutVia(x=via_xy[0], y=via_xy[1], net="+3V3")]
return LayoutGraph(
footprints={
"U1": LayoutFootprint(
reference="U1", x=0, y=0, layer=ic_layer,
pads=[LayoutPad(number="5", x=0.0, y=0.0, net="+3V3")],
courtyard=list(courtyard or []),
),
"C4": LayoutFootprint(
reference="C4", x=0.5, y=0, layer=cap_layer,
pads=[LayoutPad(number="1", x=0.5, y=0.0, net="+3V3")],
),
},
vias=vias,
)
def test_same_layer_param_opposite_layers_is_ps_plc_003():
findings = check_placement(
_graph(),
_ldo_cons(same_layer=True),
_u1_c4_layout(ic_layer="F.Cu", cap_layer="B.Cu"),
)
plc = [f for f in findings if f.rule_id == "PS-PLC-003"]
assert len(plc) == 1
assert plc[0].status == "WARNING"
assert plc[0].net == "+3V3"
assert plc[0].designator == "U1"
def test_same_layer_param_same_copper_is_silent():
assert check_placement(
_graph(),
_ldo_cons(same_layer=True),
_u1_c4_layout(ic_layer="F.Cu", cap_layer="F.Cu"),
) == []
def test_opposite_layers_without_same_layer_param_is_silent():
assert check_placement(
_graph(),
_ldo_cons(same_layer=None),
_u1_c4_layout(ic_layer="F.Cu", cap_layer="B.Cu"),
) == []
def test_opposite_layers_with_via_in_courtyard_is_silent():
courtyard = [(0.0, 0.0), (1.0, 0.0), (1.0, 1.0), (0.0, 1.0)]
findings = check_placement(
_graph(),
_ldo_cons(same_layer=True),
_u1_c4_layout(
ic_layer="F.Cu",
cap_layer="B.Cu",
via_xy=(0.5, 0.5),
courtyard=courtyard,
),
)
assert all(f.rule_id != "PS-PLC-003" for f in findings)