- These components have no datasheet on file, so they were not checked against one. A reversed or mis-wired pin on an unreviewed part (e.g. a DNP footprint with no BOM entry) cannot be caught here — verify these manually. + Each line is one designator. The reason is per part — missing + datasheet, missing library extraction, or SI re-extract needed. + Parts that were reviewed are not listed here. Review failures + (with an error message) appear under failed reviews above.
+ {certLine.notes} +
+ ) : null}{logical} → {physical} {instance.recognition ? ` · ${instance.recognition}` : ""} diff --git a/periscope/src/frontend/src/lib/protocol-report.test.ts b/periscope/src/frontend/src/lib/protocol-report.test.ts index ba613bd..208b923 100644 --- a/periscope/src/frontend/src/lib/protocol-report.test.ts +++ b/periscope/src/frontend/src/lib/protocol-report.test.ts @@ -71,7 +71,7 @@ test("protocol FAIL finding stays in Error folder with WARNING skips on same ref status: "WARNING", rule_id: "PE-PRT-L2-001", source: "protocol_l2", - finding: "non certificata a L2 per mancanza di Z", + finding: "USB not certified — because Z cannot be calculated from the PCB stackup/geometry. Cited 90 Ω.", }), ]); assert.equal(groups[0].label, "Error"); diff --git a/tests/pcb/test_af_trace_check.py b/tests/pcb/test_af_trace_check.py index f1437ea..e2fdd56 100644 --- a/tests/pcb/test_af_trace_check.py +++ b/tests/pcb/test_af_trace_check.py @@ -142,12 +142,14 @@ def test_missing_tr_f_is_visible_skip_no_ohm(): assert all(f.rule_id == "PE-AF-002" for f in out) assert len(out) == 1 text = out[0].finding - assert "Pista ad alta frequenza non controllata per mancanza di" in text + assert text.startswith("HF not certified — because") assert "tr" in text and "f" in text + assert "mancanza" not in text assert out[0].evidence_status == "INSUFFICIENT" assert out[0].finding_class == "REVIEW" blob = (out[0].finding + out[0].facts).lower() - assert "90" not in blob and "50" not in blob and "ω" not in blob and "ohm" not in blob + assert "90 Ω" not in blob and "50 Ω" not in blob + assert "invented" in blob def test_short_pair_with_tr_is_not_af(): diff --git a/tests/pcb/test_bom_esd_ep_cc_eth.py b/tests/pcb/test_bom_esd_ep_cc_eth.py index cc87cb7..c6130b7 100644 --- a/tests/pcb/test_bom_esd_ep_cc_eth.py +++ b/tests/pcb/test_bom_esd_ep_cc_eth.py @@ -328,11 +328,12 @@ def test_lan8720_pair_without_z_is_error_with_100base_cite(monkeypatch): f = findings[0] assert f.status == "ERROR" blob = f"{f.finding} {f.action} {f.requirement}" - assert blob.startswith("ERROR:") or "ERROR:" in f.finding + assert f.finding.startswith("Ethernet not certified — because Z cannot be calculated") assert "100" in blob and "25.4.9" in blob assert "stackup" in blob assert "Fornire" not in blob - assert "tr" not in blob.lower() + assert "mancanza di tr" not in blob.lower() + assert "mancanza di f" not in blob.lower() assert "90" not in blob assert "Clause 40" not in blob assert "1000BASE" not in blob @@ -342,16 +343,17 @@ def test_lan8720_pair_without_z_is_error_with_100base_cite(monkeypatch): def test_lan8720_pair_z_inside_cite_is_pass(monkeypatch): findings = _eth_findings(_eth_graph("LAN8720A"), monkeypatch, 100.0) assert len(findings) == 1 - assert findings[0].finding.startswith("PASS:") + assert findings[0].finding.startswith("Ethernet certified —") assert findings[0].status == "INFO" - assert "RJ45_TXP" in findings[0].finding and "RJ45_TXN" in findings[0].finding + assert "RJ45_TXP" in (findings[0].facts or "") or "RJ45_TXP" in findings[0].finding + assert "RJ45_TXN" in (findings[0].facts or "") or "RJ45_TXN" in findings[0].finding assert "25.4.9" in findings[0].finding def test_lan8720_pair_z_outside_cite_is_fail(monkeypatch): findings = _eth_findings(_eth_graph("LAN8720A"), monkeypatch, 90.0) assert len(findings) == 1 - assert findings[0].finding.startswith("FAIL:") + assert findings[0].finding.startswith("Ethernet not certified — because Z") assert findings[0].status == "ERROR" assert "PASS" not in findings[0].finding assert "25.4.9" in findings[0].finding diff --git a/tests/pcb/test_j2_usb_cert_line.py b/tests/pcb/test_j2_usb_cert_line.py new file mode 100644 index 0000000..bae9420 --- /dev/null +++ b/tests/pcb/test_j2_usb_cert_line.py @@ -0,0 +1,134 @@ +"""USB Type-C D+/D− one-line certification; J2 has no WARNING wall.""" + +from __future__ import annotations + +from backend.periscopex.models import ( + Component, + ComponentType, + DesignGraph, + LayoutDielectric, + LayoutGraph, + LayoutSegment, + LayoutStackup, + Net, + NetType, + PinConnection, + ResistorSpecs, +) +from backend.periscopex.protocol_l0 import protocol_exam +from backend.periscopex.protocol_l2 import certify_l2, usb_pair_z_ohm +from backend.periscopex.protocol_recognize import recognize_physical_buses + + +def _ic(ref: str, pins: dict[str, str], *, mpn: str = "") -> Component: + return Component( + reference=ref, value=mpn or ref, footprint="", + component_type=ComponentType.IC, mpn=mpn or None, pins=pins, + ) + + +def _net(name: str, *pairs: tuple[str, str]) -> Net: + return Net( + name=name, net_type=NetType.SIGNAL, + pins=[PinConnection(component_ref=r, pin_number=p) for r, p in pairs], + ) + + +def _usb_c_graph() -> DesignGraph: + return DesignGraph( + components={ + "U1": _ic("U1", {"1": "USB_D+", "2": "USB_D-"}, mpn="CH340E"), + "J2": Component( + reference="J2", value="USB_C", + footprint="Connector_USB:USB_C_Receptacle", + component_type=ComponentType.CONNECTOR, + pins={"A6": "USB_D+", "A7": "USB_D-", "A5": "CC1", "B5": "CC2", + "A4": "VBUS", "A1": "GND"}, + ), + "R1": Component( + reference="R1", value="5.1k", footprint="", + component_type=ComponentType.RESISTOR, + pins={"1": "CC1", "2": "GND"}, + specs=ResistorSpecs(value_ohms=5100.0, value_formatted="5.1k"), + ), + "R2": Component( + reference="R2", value="5.1k", footprint="", + component_type=ComponentType.RESISTOR, + pins={"1": "CC2", "2": "GND"}, + specs=ResistorSpecs(value_ohms=5100.0, value_formatted="5.1k"), + ), + }, + nets={ + "USB_D+": _net("USB_D+", ("U1", "1"), ("J2", "A6")), + "USB_D-": _net("USB_D-", ("U1", "2"), ("J2", "A7")), + "CC1": _net("CC1", ("J2", "A5"), ("R1", "1")), + "CC2": _net("CC2", ("J2", "B5"), ("R2", "1")), + "VBUS": _net("VBUS", ("J2", "A4")), + "GND": Net( + name="GND", net_type=NetType.GROUND, + pins=[ + PinConnection(component_ref="J2", pin_number="A1"), + PinConnection(component_ref="R1", pin_number="2"), + PinConnection(component_ref="R2", pin_number="2"), + ], + ), + }, + ) + + +def _stack() -> LayoutStackup: + return LayoutStackup( + copper_layers=["F.Cu", "B.Cu"], + dielectrics=[LayoutDielectric(name="core", er=4.5, height_mm=0.15)], + copper_thickness_mm=0.035, + ) + + +def test_usb_missing_z_is_one_not_certified_line(): + sec, findings = protocol_exam(_usb_c_graph()) + usb = [i for i in sec.recognized_instances if "usb" in (i.get("logical_protocol_id") or "")] + assert usb + notes = [ + c.get("notes") or "" + for row in usb + for c in (row.get("report_checks") or row.get("l2_checks") or []) + ] + cert = [n for n in notes if n.startswith("USB not certified —") or n.startswith("USB certified —")] + assert len(cert) == 1 + assert cert[0].startswith("USB not certified — because Z cannot be calculated") + assert "90" in cert[0] + # No Italian warning wall on missing fields. + j2 = [f for f in findings if f.designator == "J2" and (f.rule_id or "").startswith("PE-PRT-L")] + assert not any("mancanza" in (f.finding or "") for f in j2) + assert not any(f.rule_id == "PE-PRT-L1-001" for f in j2) + assert not any(f.rule_id == "PE-PRT-L3-001" for f in j2) + # At most one L2 cert finding for the pair (optional L0 FAIL allowed separately). + l2 = [f for f in j2 if f.rule_id == "PE-PRT-L2-002"] + assert len(l2) <= 1 + + +def test_usb_calculated_z_inside_cite_is_certified(monkeypatch): + graph = _usb_c_graph() + layout = LayoutGraph( + segments=[ + LayoutSegment(start=(0, 0), end=(20, 0), width=0.2, layer="F.Cu", net="USB_D+"), + LayoutSegment(start=(0, 0.15), end=(20, 0.15), width=0.2, layer="F.Cu", net="USB_D-"), + ], + stackup=_stack(), + ) + monkeypatch.setattr( + "backend.periscopex.protocol_l2.usb_pair_z_ohm", + lambda layout, nets, impedance_nets: (90.0, ""), + ) + insts = recognize_physical_buses(graph) + _by, findings = certify_l2(graph, insts, layout=layout) + lines = [f.finding for f in findings if (f.finding or "").startswith("USB certified —")] + assert len(lines) == 1 + assert "90" in lines[0] + assert "not invented" not in lines[0].lower() + + +def test_usb_pair_z_reports_missing_geometry(): + z, missing = usb_pair_z_ohm(None, ("USB_D+", "USB_D-"), None) + assert z is None + assert "stackup" in missing or "geometry" in missing diff --git a/tests/pcb/test_not_reviewed_count.py b/tests/pcb/test_not_reviewed_count.py new file mode 100644 index 0000000..f76ac73 --- /dev/null +++ b/tests/pcb/test_not_reviewed_count.py @@ -0,0 +1,131 @@ +"""not_reviewed count matches list; pcb_review error is not a blanket label.""" + +from __future__ import annotations + +import asyncio +from pathlib import Path +from unittest.mock import AsyncMock, patch + +from backend.periscopex.models import Component, ComponentConstraints, ComponentType, DesignGraph, Pin +from backend.periscopex.pcb_checks import merge_schema_pcb_reports +from backend.periscopex.review_parse import ReviewResult +from backend.services.pcb_validation import review_pcb_ics + + +def test_merge_expands_joined_designators_and_matches_count(): + schema = { + "findings": [], + "coverage": {"U1": ["power"]}, + "not_reviewed": [ + {"designator": "U2,U3,U4", "reason": "no datasheet PDF"}, + ], + } + pcb = { + "findings": [], + "coverage": {"U5": ["layout"]}, + "not_reviewed": [ + {"designator": "U6", "reason": "no library extraction — run schematic review first"}, + {"designator": "U1", "reason": "pcb_review error"}, # reviewed → drop + {"designator": "U7", "reason": "pcb_review error"}, # → review_errors + ], + "review_errors": {}, + } + merged = merge_schema_pcb_reports(schema, pcb) + nr = merged["not_reviewed"] + refs = [r["designator"] for r in nr] + assert refs == ["U2", "U3", "U4", "U6"] + assert len(nr) == len(refs) + assert "U1" not in refs # covered + assert "U7" not in refs + assert merged["review_errors"]["U7"] == "pcb_review error" + assert "pcb_review error" not in {r["reason"] for r in nr} + + +def test_merge_does_not_list_reviewed_as_not_reviewed(): + schema = { + "findings": [], + "coverage": {"U10": ["abs_max"], "U11": ["pinout"]}, + "not_reviewed": [{"designator": "U10", "reason": "no datasheet PDF"}], + } + pcb = { + "findings": [], + "coverage": {"U11": ["layout"]}, + "not_reviewed": [{"designator": "U11", "reason": "pcb_review error"}], + } + merged = merge_schema_pcb_reports(schema, pcb) + assert merged["not_reviewed"] == [] + + +def test_pcb_review_exception_goes_to_review_errors_not_not_reviewed(): + graph = DesignGraph( + components={ + "U1": Component( + reference="U1", value="LAN8720A", footprint="", + component_type=ComponentType.IC, mpn="LAN8720A", + pins={"1": "TXEN"}, + ), + }, + nets={}, + ) + cons = ComponentConstraints( + mpn="LAN8720A", + pintable=[Pin(number="1", name="TXEN")], + absolute_maximum_ratings=[], + rules=[], + ) + + async def _boom(*_a, **_k): + raise RuntimeError("model timeout") + + async def _run(): + with patch( + "backend.services.pcb_validation.review_ic_async", + new=AsyncMock(side_effect=_boom), + ): + return await review_pcb_ics( + graph, {"LAN8720A": cons}, None, None, None, Path("/tmp"), + ) + + findings, coverage, skipped, errors = asyncio.run(_run()) + assert findings == [] + assert coverage == {} + assert skipped == [] + assert "U1" in errors + assert "RuntimeError" in errors["U1"] + assert "pcb_review error" not in errors["U1"] + + +def test_successful_pcb_review_is_covered_not_skipped(): + graph = DesignGraph( + components={ + "U1": Component( + reference="U1", value="X", footprint="", + component_type=ComponentType.IC, mpn="HASPINTABLE", + pins={"1": "GND"}, + ), + }, + nets={}, + ) + cons = ComponentConstraints( + mpn="HASPINTABLE", + pintable=[Pin(number="1", name="GND")], + absolute_maximum_ratings=[], + rules=[], + ) + + async def _ok(*_a, **_k): + return ReviewResult([], []), {} + + async def _run(): + with patch( + "backend.services.pcb_validation.review_ic_async", + new=AsyncMock(side_effect=_ok), + ): + return await review_pcb_ics( + graph, {"HASPINTABLE": cons}, None, None, None, Path("/tmp"), + ) + + _f, coverage, skipped, errors = asyncio.run(_run()) + assert coverage == {"U1": ["layout"]} + assert skipped == [] + assert errors == {} diff --git a/tests/pcb/test_pcb_review.py b/tests/pcb/test_pcb_review.py index 81eda7b..19f6d3a 100644 --- a/tests/pcb/test_pcb_review.py +++ b/tests/pcb/test_pcb_review.py @@ -619,8 +619,9 @@ def test_pcb_ai_skips_without_library_extraction(): graph, {}, None, None, None, Path("/tmp"), ) - _f, _c, skipped = asyncio.run(_run()) + _f, _c, skipped, errors = asyncio.run(_run()) assert skipped + assert errors == {} assert "library extraction" in skipped[0]["reason"] diff --git a/tests/pcb/test_protocol_l1_m3.py b/tests/pcb/test_protocol_l1_m3.py index 0448f0c..b391fb4 100644 --- a/tests/pcb/test_protocol_l1_m3.py +++ b/tests/pcb/test_protocol_l1_m3.py @@ -155,8 +155,7 @@ def test_usb_no_layout_is_visible_skip_not_pass(): assert rows assert all(r.result != "PASS" or r.check == "never" for r in rows) assert any(r.result == "UNKNOWN" for r in rows) - assert any(f.rule_id == "PE-PRT-L1-001" for f in findings) - assert any("non certificata a L1" in (f.finding or "") for f in findings) + assert not any(f.rule_id == "PE-PRT-L1-001" for f in findings) def test_axi_internal_l1_not_applicable(): diff --git a/tests/pcb/test_protocol_l2_m4.py b/tests/pcb/test_protocol_l2_m4.py index 75f7324..d3e7e78 100644 --- a/tests/pcb/test_protocol_l2_m4.py +++ b/tests/pcb/test_protocol_l2_m4.py @@ -109,21 +109,25 @@ def test_usb_z_missing_source_never_invents_90(): rows, findings, _ = _l2_for(_usb_connected(), "usb2", impedance_nets=zrep) z = [r for r in rows if r.check == "differential_impedance"] assert z - assert z[0].result in {"MISSING_SOURCE", "UNKNOWN"} - assert z[0].result != "PASS" - blob = json.dumps(z[0].model_dump()) - assert "90" not in blob - assert any(f.rule_id == "PE-PRT-L2-001" for f in findings) - assert any("non certificata a L2" in (f.finding or "") for f in findings) + assert z[0].result == "FAIL" + assert z[0].limit_ohm == 90.0 + assert z[0].measured_ohm is None + line = z[0].notes + assert line.startswith("USB not certified — because Z cannot be calculated") + assert "90" in line + assert "not invented" not in line.lower() + assert not any(f.rule_id == "PE-PRT-L2-001" for f in findings) + assert any(f.finding == line for f in findings) def test_usb_z_skip_when_no_stackup_measurement(): rows, findings, _ = _l2_for(_usb_connected(), "usb2") z = [r for r in rows if r.check == "differential_impedance"] assert z - assert z[0].result in {"MISSING_SOURCE", "UNKNOWN"} + assert z[0].result == "FAIL" assert z[0].measured_ohm is None - assert any("mancanza di Z" in (f.finding or "") for f in findings) + assert z[0].limit_ohm == 90.0 + assert any(f.finding.startswith("USB not certified —") for f in findings) def test_cited_pack_z_pass_and_fail(): @@ -220,7 +224,7 @@ def test_ddr_impedance_phy_dependent_not_invented_ohm(): blob = json.dumps(z[0].model_dump()) assert "40" not in blob assert "90" not in blob - assert any(f.rule_id == "PE-PRT-L2-001" for f in findings) + assert not any(f.rule_id == "PE-PRT-L2-001" for f in findings) def test_length_is_not_delay_timing_unknown(): diff --git a/tests/pcb/test_protocol_l3_m9.py b/tests/pcb/test_protocol_l3_m9.py index 281ccae..3b8fe16 100644 --- a/tests/pcb/test_protocol_l3_m9.py +++ b/tests/pcb/test_protocol_l3_m9.py @@ -173,6 +173,7 @@ def test_remaining_margin_is_total_minus_used(): def test_usb_hdmi_pcie_skip_without_channel_data(): + """No channel FACT → no L3 warning wall (silence, not Italian mancanza).""" for graph, token in ((_usb_connected(), "usb"), (_hdmi_graph(), "hdmi"), (_pcie_graph(), "pcie")): sec, findings = protocol_exam(graph) assert sec.max_level_reached == "L3" @@ -183,17 +184,9 @@ def test_usb_hdmi_pcie_skip_without_channel_data(): or token in str(r.get("physical_interface_id")).lower() ) l3 = row["l3_checks"] - assert l3 - names = {c["check"] for c in l3} - assert {"timing_budget", "insertion_loss", "return_loss", "crosstalk", "channel"} <= names - assert all(c["result"] != "PASS" for c in l3) - notes = " ".join(c.get("notes") or "" for c in l3) - assert "non certificata a L3 per mancanza" in notes - assert "OpenEMS" in notes - blob = json.dumps(l3) - assert "90" not in blob - assert any(f.rule_id == "PE-PRT-L3-001" for f in findings) - assert "s21" not in blob.lower() or "invent" in notes.lower() + assert l3 == [] + assert not any(f.rule_id == "PE-PRT-L3-001" for f in findings) + assert not any("mancanza" in (f.finding or "") for f in findings if f.source == "protocol_l3") def test_axi_l3_not_applicable_not_fail(): @@ -269,13 +262,8 @@ def test_raw_touchstone_without_fact_is_skip_not_invented(): inst = _inst() data = {inst.instance_id: {"sparam_file": "lane.s4p", "touchstone": "lane.s4p"}} rows = certify_instance_l3(inst, iface, channel_data=data) - assert all(r.result != "PASS" for r in rows) - notes = " ".join(r.notes for r in rows) - assert "non certificata a L3" in notes - assert "invent" in notes.lower() or "non inventati" in notes.lower() or "not invented" in notes.lower() - blob = json.dumps([r.model_dump() for r in rows]) - # no synthesized S21 numbers - assert '"measured_db": null' in blob or all(r.measured_db is None for r in rows) + # Raw S-param file is not reduced channel FACT — omit L3 (no warning wall). + assert rows == [] def test_openems_method_is_explicit_skip(): @@ -289,8 +277,8 @@ def test_openems_method_is_explicit_skip(): } } rows = certify_instance_l3(inst, iface, channel_data=data) - notes = " ".join(r.notes for r in rows) - assert "non certificata a L3" in notes + # OpenEMS/FEM is out of product — omit L3 rather than invent S-parameters. + assert rows == [] assert all(r.result != "PASS" for r in rows) @@ -298,19 +286,16 @@ def test_no_sparam_invention_on_empty_channel_data(): insts = recognize_physical_buses(_usb_connected()) by, findings = certify_l3(insts, channel_data=None) rows = [r for lst in by.values() for r in lst] - blob = json.dumps([r.model_dump() for r in rows]) - assert "s21" not in blob.lower() - assert all(r.measured_db is None for r in rows) - assert any("mancanza" in r.notes for r in rows) - assert any(f.rule_id == "PE-PRT-L3-001" for f in findings) + assert rows == [] + assert not any(f.rule_id == "PE-PRT-L3-001" for f in findings) def test_protocol_exam_attaches_l3_and_does_not_call_l0_electrical(): sec, _ = protocol_exam(_usb_connected()) row = sec.recognized_instances[0] - assert row.get("l3_checks") - assert all(c.get("level") == "L3" for c in row["l3_checks"]) - notes = " ".join(c.get("notes") or "" for c in row["l3_checks"]) - assert "L0/L1 are not electrical" in notes + # L3 omitted without channel FACT; L0/L1/L2 still attached. + assert row.get("l3_checks") == [] + assert row.get("l0_checks") + assert row.get("l2_checks") l0notes = json.dumps(row.get("l0_checks") or []) assert "ohm" not in l0notes.lower() or "not" in l0notes.lower() diff --git a/tests/pcb/test_protocol_report_m5.py b/tests/pcb/test_protocol_report_m5.py index 5531f26..5adab32 100644 --- a/tests/pcb/test_protocol_report_m5.py +++ b/tests/pcb/test_protocol_report_m5.py @@ -93,7 +93,7 @@ def test_result_rank_fail_before_warning(): assert instance_worst_result(["UNKNOWN", "FAIL", "PASS"]) == "FAIL" -def test_usb2_pair_l0_pass_l2_z_unknown_no_invented_ohm(): +def test_usb2_pair_l0_pass_l2_z_cert_line(): sec, _ = protocol_exam(_usb_connected()) assert sec.max_level_reached == "L3" assert sec.macrophase == "M9" @@ -106,20 +106,19 @@ def test_usb2_pair_l0_pass_l2_z_unknown_no_invented_ohm(): assert l0_topo and l0_topo[0]["result"] == "PASS" z = [c for c in checks if c["check"] == "differential_impedance"] assert z - assert z[0]["result"] in {"MISSING_SOURCE", "UNKNOWN"} - assert z[0]["skip_visible"] is True - assert z[0]["measured"] is None - assert z[0]["limit"] is None - blob = json.dumps(z[0]) - assert "90" not in blob + assert z[0]["result"] == "FAIL" + assert z[0]["limit"] == 90.0 or (z[0].get("notes") or "").find("90") >= 0 + notes = z[0].get("notes") or "" + assert notes.startswith("USB not certified —") + assert "90" in notes + assert "not invented" not in notes.lower() chain = z[0]["chain"] assert chain["physical_interface_id"] assert chain["logical_protocol_id"] assert chain["physical_interface_id"] != chain["logical_protocol_id"] + # No L3 warning wall without channel FACT. l3 = [c for c in checks if c["level"] == "L3"] - assert l3 and l3[0]["skip_visible"] - assert l3[0]["result"] != "PASS" - assert "OpenEMS" in l3[0]["notes"] + assert l3 == [] def test_fail_listed_before_warning_in_report_checks(): diff --git a/tests/pcb/test_rmii_cert_line.py b/tests/pcb/test_rmii_cert_line.py new file mode 100644 index 0000000..9061c7f --- /dev/null +++ b/tests/pcb/test_rmii_cert_line.py @@ -0,0 +1,110 @@ +"""RMII PHY–MAC is not RJ45 100 Ω; one English certification line.""" + +from __future__ import annotations + +from backend.periscopex.af_trace_check import check_af_traces +from backend.periscopex.models import ( + Component, + ComponentType, + DesignGraph, + LayoutDielectric, + LayoutGraph, + LayoutSegment, + LayoutStackup, + Net, + NetType, + PinConnection, +) +from backend.periscopex.si_check import bus_class, phy_mac_kind, single_ended_eth_mac + + +def _ic(ref: str, mpn: str, pins: dict[str, str]) -> Component: + return Component( + reference=ref, value=mpn, footprint="", + component_type=ComponentType.IC, mpn=mpn, pins=pins, + ) + + +def _net(name: str, *pairs: tuple[str, str]) -> Net: + return Net( + name=name, net_type=NetType.SIGNAL, + pins=[PinConnection(component_ref=r, pin_number=p) for r, p in pairs], + ) + + +def _rmii_graph() -> DesignGraph: + return DesignGraph( + components={ + "U19": _ic("U19", "LAN8720A", { + "1": "ETH_RXD0", "2": "ETH_RXD1", + "3": "ETH_TXD0", "4": "ETH_TXD1", "5": "ETH_TXEN", + }), + "U3": _ic("U3", "MCU", { + "10": "ETH_RXD0", "11": "ETH_RXD1", + "12": "ETH_TXD0", "13": "ETH_TXD1", "14": "ETH_TXEN", + }), + }, + nets={ + "ETH_RXD0": _net("ETH_RXD0", ("U19", "1"), ("U3", "10")), + "ETH_RXD1": _net("ETH_RXD1", ("U19", "2"), ("U3", "11")), + "ETH_TXD0": _net("ETH_TXD0", ("U19", "3"), ("U3", "12")), + "ETH_TXD1": _net("ETH_TXD1", ("U19", "4"), ("U3", "13")), + "ETH_TXEN": _net("ETH_TXEN", ("U19", "5"), ("U3", "14")), + }, + ) + + +def _layout() -> LayoutGraph: + segs = [] + y = 0.0 + for net in ("ETH_RXD0", "ETH_RXD1", "ETH_TXD0", "ETH_TXD1", "ETH_TXEN"): + segs.append(LayoutSegment( + start=(0, y), end=(40, y), width=0.15, layer="F.Cu", net=net, + )) + y += 0.5 + return LayoutGraph( + segments=segs, + stackup=LayoutStackup( + copper_layers=["F.Cu", "B.Cu"], + dielectrics=[LayoutDielectric(name="core", er=4.5, height_mm=0.15)], + copper_thickness_mm=0.035, + ), + ) + + +def test_eth_rxd_is_rmii_not_mdi(): + for n in ("ETH_RXD0", "ETH_TXD0", "ETH_TXEN"): + assert single_ended_eth_mac(n) + assert bus_class(n) == "rmii" + assert phy_mac_kind(n) == "rmii" + assert bus_class(n) != "eth_mdi" + + +def test_rmii_one_certified_line_no_italian_tr_f(): + findings = check_af_traces(_rmii_graph(), {}, _layout()) + rmii = [f for f in findings if (f.finding or "").startswith("RMII certified —")] + assert len(rmii) == 1 + blob = rmii[0].finding + assert "ETH_RXD" in blob or "ETH_TXD" in blob or "ETH_TXEN" in blob + assert "not an RJ45/MDI" in blob or "not an RJ45" in blob + assert "mancanza" not in blob + assert not any( + "mancanza di tr" in (f.finding or "") or "mancanza di f" in (f.finding or "") + for f in findings + ) + assert not any( + f.rule_id == "PE-AF-002" and any( + single_ended_eth_mac(n) for n in ((f.net,) if f.net else ()) + ) + for f in findings + ) + + +def test_rmii_not_given_100_ohm_mdi_finding(): + findings = check_af_traces(_rmii_graph(), {}, _layout()) + assert not any("25.4.9" in (f.finding or "") for f in findings) + assert not any( + f.finding.startswith("Ethernet certified") or f.finding.startswith("Ethernet not certified") + for f in findings + if f.net and single_ended_eth_mac(f.net) + )