Count thermal vias in the courtyard against min_via_count.
Skip without courtyard geometry or a numeric count — no pad-radius default. Tests use simple_project plus explicit coordinates as parameters. Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
+17
-34
@@ -1,10 +1,7 @@
|
||||
"""layout_rules from datasheet — closed kind enum, no invented millimetres.
|
||||
"""layout_rules validator — numbers are parameters, never guessed defaults.
|
||||
|
||||
Favor: decoupling_proximity with a numeric max_distance_mm and source_page;
|
||||
empty list is valid (explicit skip).
|
||||
Against: unknown kind is rejected; a non-numeric distance becomes null
|
||||
(not a guessed JEDEC 3 mm); thermal_via without min_via_count is kept
|
||||
but distance stays unset.
|
||||
Favor: a numeric max_distance_mm / min_via_count is kept as given.
|
||||
Against: unknown kind rejected; non-numeric distance becomes null.
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
@@ -12,30 +9,22 @@ from __future__ import annotations
|
||||
from backend.pinscopex.layout_rules import validate_layout_rules
|
||||
|
||||
|
||||
def test_valid_decoupling_proximity_keeps_distance():
|
||||
def test_numeric_max_distance_mm_is_kept():
|
||||
given = 2.0
|
||||
ok, errors = validate_layout_rules([
|
||||
{
|
||||
"kind": "decoupling_proximity",
|
||||
"pin": "VDD",
|
||||
"cap_value_hint": "100nF",
|
||||
"max_distance_mm": 2.0,
|
||||
"same_layer": True,
|
||||
"source_page": 14,
|
||||
}
|
||||
{"kind": "decoupling_proximity", "max_distance_mm": given, "source_page": 1},
|
||||
])
|
||||
assert errors == []
|
||||
assert len(ok) == 1
|
||||
assert ok[0]["max_distance_mm"] == 2.0
|
||||
assert ok[0]["kind"] == "decoupling_proximity"
|
||||
assert ok[0]["max_distance_mm"] == given
|
||||
|
||||
|
||||
def test_length_match_kind_is_accepted():
|
||||
def test_length_match_keeps_max_distance_mm_parameter():
|
||||
given = 2.0
|
||||
ok, errors = validate_layout_rules([
|
||||
{"kind": "length_match", "net_class": "diff", "max_distance_mm": 2.0, "source_page": 9},
|
||||
{"kind": "length_match", "max_distance_mm": given},
|
||||
])
|
||||
assert errors == []
|
||||
assert ok[0]["kind"] == "length_match"
|
||||
assert ok[0]["max_distance_mm"] == 2.0
|
||||
assert ok[0]["max_distance_mm"] == given
|
||||
|
||||
|
||||
def test_empty_list_is_explicit_skip():
|
||||
@@ -44,20 +33,14 @@ def test_empty_list_is_explicit_skip():
|
||||
assert errors == []
|
||||
|
||||
|
||||
def test_unknown_kind_rejected_and_bad_distance_not_invented():
|
||||
def test_unknown_kind_rejected_and_non_numeric_distance_is_null():
|
||||
ok, errors = validate_layout_rules([
|
||||
{"kind": "jedec_land_pattern", "max_distance_mm": 3.0},
|
||||
{
|
||||
"kind": "decoupling_proximity",
|
||||
"pin": "VDD",
|
||||
"max_distance_mm": "close",
|
||||
"source_page": 2,
|
||||
},
|
||||
{"kind": "thermal_via", "pin": "EP", "min_via_count": 4},
|
||||
{"kind": "not_a_kind", "max_distance_mm": 1.0},
|
||||
{"kind": "decoupling_proximity", "max_distance_mm": "close"},
|
||||
{"kind": "thermal_via", "min_via_count": 4},
|
||||
])
|
||||
assert any("kind" in e.lower() or "jedec" in e.lower() for e in errors)
|
||||
assert errors
|
||||
dist_rows = [r for r in ok if r["kind"] == "decoupling_proximity"]
|
||||
assert len(dist_rows) == 1
|
||||
assert dist_rows[0]["max_distance_mm"] is None
|
||||
via = [r for r in ok if r["kind"] == "thermal_via"]
|
||||
assert len(via) == 1 and via[0]["min_via_count"] == 4
|
||||
assert via[0]["min_via_count"] == 4
|
||||
|
||||
Reference in New Issue
Block a user