perf(v2): word-level burst reads - 2.24-2.37x real wall-clock speedup (DEC-0015)
Implements optimization #1 from the final benchmark campaign's own recommendation: exploit psram_controller.v's already-implemented page-mode support (confirmed present by direct inspection) by fetching multiple bytes per real backend transaction instead of one at a time. Root cause addressed: int8_memory_access.v (the byte-level backend prefetch_engine.v originally sat on) already converts every 8-bit logical request into a full 16-bit PSRAM word access internally (mem_addr <= addr >> 1), discarding half of every word it already paid for. prefetch_engine.v/memory_manager.v now speak memory_interface.v's own 16-bit word protocol directly, bypassing int8_memory_access.v entirely - which remains untouched, still frozen V1 (§1/§34); V2 simply reuses the lower layer of the same frozen chain instead of the byte-splitting layer on top of it, the same "reuse what fits" precedent slot_mem_arbiter.v already set. slot_mem_arbiter.v and neural_multiprocessor.v widened to match (lb_n/ub_n added, master port wired directly to memory_interface.v). Real, measured results: M4's own single-job testbench shows 49-56% fewer cycles (166->84, 446->204, 728->322, all still bit-exact). The full final-benchmark campaign (24/24 workload/config combinations) re-verified bit-exact with D-Stress's real wall-clock time (cycles / real POST-P&R Fmax) improving 2.24-2.37x across every N_SLOTS tested, against a small real Fmax cost (unchanged at N=1, -6.2% at N=2, -1.2% at N=4). tb_neural_multiprocessor.v (M8) and tb_benchmark_suite.v (final campaign) needed zero changes - both treat neural_multiprocessor.v as a black box. Only tb_memory_manager.v (M4, rewired to skip int8_memory_access.v) and tb_dataflow_core.v (M7, behavioral model widened to word-level) needed updates. The "real parallel scaling is flat beyond N_SLOTS=2" finding (DEC-0014) still holds - this optimization made the shared PSRAM port more efficient per transaction, not multi-ported - so N_SLOTS=2 remains the recommended default. Logged: simulation/synthesis/timing/benchmark/decisions (DEC-0015)/ experiments (EXP-0015)/development.log. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013xXuuRUWZScuo1DeYJxs3v
This commit is contained in:
@@ -1,26 +1,43 @@
|
||||
`timescale 1ns/1ps
|
||||
|
||||
// ================================================================
|
||||
// FPGA-Neural V2 -- Prefetch Engine (M4, docs/v2-description.md §13)
|
||||
// FPGA-Neural V2 -- Prefetch Engine (M4, docs/v2-description.md §13;
|
||||
// word-level burst rewrite post-M10 -- see hardware/v2/logs/
|
||||
// decisions.log DEC-0015)
|
||||
//
|
||||
// Fetches ONE tile (P_IN activation bytes + P_IN weight bytes) from
|
||||
// the byte-level Memory Backend Interface into a pair of output
|
||||
// registers, sequentially (2*P_IN single-byte transactions -- the
|
||||
// same byte-at-a-time convention hardware/v1/rtl/neuron_memory.v
|
||||
// already uses against the same backend, reused unmodified here).
|
||||
// the WORD-level Memory Backend Interface, P_IN/2 sixteen-bit
|
||||
// transactions per array instead of P_IN single-byte ones.
|
||||
//
|
||||
// This module fetches exactly one tile per fetch_start pulse; the
|
||||
// double-buffering strategy itself (§13: compute tile N while
|
||||
// prefetching tile N+1, swap, repeat) is memory_manager.v's
|
||||
// responsibility -- it retargets this single engine at whichever
|
||||
// bank currently needs refilling, so no internal arbitration between
|
||||
// multiple fetch engines sharing the backend port is ever needed.
|
||||
// WHY: hardware/v1/rtl/int8_memory_access.v (the byte-level backend
|
||||
// this engine originally sat on) converts every 8-bit logical request
|
||||
// into a FULL 16-bit PSRAM word access internally (mem_addr <= addr
|
||||
// >> 1, one byte lane selected via lb_n/ub_n) -- so a byte-at-a-time
|
||||
// fetch was ALREADY paying for two bytes of real PSRAM bandwidth per
|
||||
// transaction while only using one. This engine now talks directly to
|
||||
// hardware/v1/rtl/memory_interface.v's own 16-bit word interface
|
||||
// (skipping int8_memory_access.v entirely -- both are frozen V1 files,
|
||||
// unmodified either way, §1/§34; V2 is simply choosing to reuse the
|
||||
// lower layer instead of the byte-splitting one on top of it, the
|
||||
// same "reuse what fits" precedent already set by slot_mem_arbiter.v
|
||||
// not reusing hardware/v1/rtl/mem_arbiter.v verbatim). psram_controller.v's
|
||||
// own real page-mode support (already implemented, unmodified) then
|
||||
// serves consecutive same-page word reads faster than a cold access --
|
||||
// this engine's job is simply to stop discarding half of every word it
|
||||
// already paid for, and to halve the number of real backend
|
||||
// round-trips needed per tile.
|
||||
//
|
||||
// The backend port (mem_req/mem_wr/mem_addr/mem_wdata/mem_rdata/
|
||||
// mem_ready) matches hardware/v1/rtl/int8_memory_access.v's contract
|
||||
// exactly -- this engine can sit directly on top of that unmodified
|
||||
// V1 module (which itself sits on memory_interface.v ->
|
||||
// psram_controller.v, also unmodified, per §15).
|
||||
// CONSTRAINT: P_IN must be even, and x_addr/w_addr must be word-
|
||||
// aligned (even BYTE addresses) -- each 16-bit transaction covers
|
||||
// BYTE addresses {addr, addr+1} as {low byte, high byte} (matches
|
||||
// int8_memory_access.v's own addr[0] convention exactly, replicated
|
||||
// here since that module is no longer in the datapath). A host/loader
|
||||
// placing X/W tile arrays at even byte offsets (already true of every
|
||||
// address used in this project's own testbenches) satisfies this
|
||||
// with no special handling.
|
||||
//
|
||||
// The double-buffering strategy itself (§13) remains memory_manager.v's
|
||||
// responsibility -- unchanged by this rewrite.
|
||||
// ================================================================
|
||||
|
||||
module prefetch_engine #(
|
||||
@@ -32,18 +49,22 @@ module prefetch_engine #(
|
||||
input wire rst,
|
||||
|
||||
input wire fetch_start,
|
||||
input wire [ADDR_WIDTH-1:0] x_addr, // base addr of this tile's P_IN X bytes
|
||||
input wire [ADDR_WIDTH-1:0] w_addr, // base addr of this tile's P_IN W bytes
|
||||
input wire [ADDR_WIDTH-1:0] x_addr, // BYTE address, word-aligned
|
||||
input wire [ADDR_WIDTH-1:0] w_addr, // BYTE address, word-aligned
|
||||
output reg fetch_busy,
|
||||
output reg fetch_done, // one-cycle pulse
|
||||
output reg signed [DATA_WIDTH*P_IN-1:0] tile_x,
|
||||
output reg signed [DATA_WIDTH*P_IN-1:0] tile_w,
|
||||
|
||||
// ---- word-level Memory Backend Interface (matches
|
||||
// hardware/v1/rtl/memory_interface.v's contract exactly) ----
|
||||
output reg mem_req,
|
||||
output reg mem_wr,
|
||||
output reg [ADDR_WIDTH-1:0] mem_addr,
|
||||
output reg signed [7:0] mem_wdata,
|
||||
input wire signed [7:0] mem_rdata,
|
||||
output reg [ADDR_WIDTH-1:0] mem_addr, // WORD address
|
||||
output reg [15:0] mem_wdata,
|
||||
output reg mem_lb_n,
|
||||
output reg mem_ub_n,
|
||||
input wire [15:0] mem_rdata,
|
||||
input wire mem_ready
|
||||
);
|
||||
|
||||
@@ -52,19 +73,27 @@ module prefetch_engine #(
|
||||
localparam ST_READ_W = 2'd2;
|
||||
localparam ST_DONE = 2'd3;
|
||||
|
||||
localparam WORDS_PER_TILE = P_IN/2;
|
||||
localparam WIW = $clog2(WORDS_PER_TILE+1);
|
||||
|
||||
reg [1:0] state;
|
||||
reg [$clog2(P_IN+1)-1:0] byte_idx;
|
||||
reg [WIW-1:0] word_idx;
|
||||
|
||||
wire [ADDR_WIDTH-1:0] x_word_base = x_addr[ADDR_WIDTH-1:1];
|
||||
wire [ADDR_WIDTH-1:0] w_word_base = w_addr[ADDR_WIDTH-1:1];
|
||||
|
||||
always @(posedge clk) begin
|
||||
if (rst) begin
|
||||
state <= ST_IDLE;
|
||||
byte_idx <= 0;
|
||||
word_idx <= 0;
|
||||
fetch_busy <= 1'b0;
|
||||
fetch_done <= 1'b0;
|
||||
mem_req <= 1'b0;
|
||||
mem_wr <= 1'b0;
|
||||
mem_addr <= {ADDR_WIDTH{1'b0}};
|
||||
mem_wdata <= 8'sd0;
|
||||
mem_wdata <= 16'h0000;
|
||||
mem_lb_n <= 1'b1;
|
||||
mem_ub_n <= 1'b1;
|
||||
end else begin
|
||||
mem_req <= 1'b0;
|
||||
fetch_done <= 1'b0;
|
||||
@@ -74,42 +103,50 @@ module prefetch_engine #(
|
||||
ST_IDLE: begin
|
||||
if (fetch_start) begin
|
||||
fetch_busy <= 1'b1;
|
||||
byte_idx <= 0;
|
||||
word_idx <= 0;
|
||||
mem_req <= 1'b1;
|
||||
mem_wr <= 1'b0;
|
||||
mem_addr <= x_addr;
|
||||
mem_addr <= x_word_base;
|
||||
mem_lb_n <= 1'b0; // both byte lanes -- fetch the whole word
|
||||
mem_ub_n <= 1'b0;
|
||||
state <= ST_READ_X;
|
||||
end
|
||||
end
|
||||
|
||||
ST_READ_X: begin
|
||||
if (mem_ready) begin
|
||||
tile_x[byte_idx*DATA_WIDTH +: DATA_WIDTH] <= mem_rdata;
|
||||
if (byte_idx == P_IN[$clog2(P_IN+1)-1:0] - 1'b1) begin
|
||||
byte_idx <= 0;
|
||||
tile_x[word_idx*16 +: 16] <= mem_rdata;
|
||||
if (word_idx == WORDS_PER_TILE[WIW-1:0] - 1'b1) begin
|
||||
word_idx <= 0;
|
||||
mem_req <= 1'b1;
|
||||
mem_wr <= 1'b0;
|
||||
mem_addr <= w_addr;
|
||||
mem_addr <= w_word_base;
|
||||
mem_lb_n <= 1'b0;
|
||||
mem_ub_n <= 1'b0;
|
||||
state <= ST_READ_W;
|
||||
end else begin
|
||||
byte_idx <= byte_idx + 1'b1;
|
||||
word_idx <= word_idx + 1'b1;
|
||||
mem_req <= 1'b1;
|
||||
mem_wr <= 1'b0;
|
||||
mem_addr <= x_addr + byte_idx + 1'b1;
|
||||
mem_addr <= x_word_base + word_idx + 1'b1;
|
||||
mem_lb_n <= 1'b0;
|
||||
mem_ub_n <= 1'b0;
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
ST_READ_W: begin
|
||||
if (mem_ready) begin
|
||||
tile_w[byte_idx*DATA_WIDTH +: DATA_WIDTH] <= mem_rdata;
|
||||
if (byte_idx == P_IN[$clog2(P_IN+1)-1:0] - 1'b1) begin
|
||||
tile_w[word_idx*16 +: 16] <= mem_rdata;
|
||||
if (word_idx == WORDS_PER_TILE[WIW-1:0] - 1'b1) begin
|
||||
state <= ST_DONE;
|
||||
end else begin
|
||||
byte_idx <= byte_idx + 1'b1;
|
||||
word_idx <= word_idx + 1'b1;
|
||||
mem_req <= 1'b1;
|
||||
mem_wr <= 1'b0;
|
||||
mem_addr <= w_addr + byte_idx + 1'b1;
|
||||
mem_addr <= w_word_base + word_idx + 1'b1;
|
||||
mem_lb_n <= 1'b0;
|
||||
mem_ub_n <= 1'b0;
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user