Fix web radio streaming stutter: batch I2S writes, widen DMA buffer

writeFrame() called i2s_channel_write() once per decoded PCM sample (up to
1152 separate driver calls per MP3 frame), each with its own locking/DMA
bookkeeping overhead. Now accumulates a whole frame into one buffer and
writes it in a single call.

The I2S TX channel also used the ESP-IDF default DMA config (6 descriptors
x 240 frames = ~30 ms of buffering at 48 kHz), leaving almost no headroom
against network jitter in this single-task fetch+decode+play pipeline.
Widened to 12 x 480 (~120 ms) so a brief HTTP stall doesn't immediately
starve the DMA and audibly crackle.

Both are static/architectural fixes verified by build only — not confirmed
live yet (board disconnected this session).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0178rASQ6ZETPMUamvpoR2KR
This commit is contained in:
2026-08-18 07:50:48 +02:00
co-authored by Claude Sonnet 5
parent 3a10ed75aa
commit 7e65394100
+25 -8
View File
@@ -46,6 +46,12 @@ struct InputBuffer {
{ {
i2s_chan_config_t chanCfg = i2s_chan_config_t chanCfg =
I2S_CHANNEL_DEFAULT_CONFIG(I2S_NUM_0, I2S_ROLE_SLAVE); I2S_CHANNEL_DEFAULT_CONFIG(I2S_NUM_0, I2S_ROLE_SLAVE);
// Default (6 desc x 240 frames = 1440 frames = ~30 ms @ 48 kHz) leaves
// almost no headroom against network jitter in this single-task
// fetch+decode+play pipeline; widen it to ~120 ms so a brief HTTP
// stall doesn't immediately starve the I2S DMA and audibly crackle.
chanCfg.dma_desc_num = 12;
chanCfg.dma_frame_num = 480;
i2s_chan_handle_t txHandle = nullptr; i2s_chan_handle_t txHandle = nullptr;
if (i2s_new_channel(&chanCfg, &txHandle, nullptr) != ESP_OK) { if (i2s_new_channel(&chanCfg, &txHandle, nullptr) != ESP_OK) {
ESP_LOGE(kTag, "i2s_new_channel failed"); ESP_LOGE(kTag, "i2s_new_channel failed");
@@ -135,20 +141,31 @@ void refill(esp_http_client_handle_t client, InputBuffer& in)
in.readPtr = in.data; in.readPtr = in.data;
} }
/** Convert one decoded PCM frame to the ADAU's 32-bit-slot I2S format. */ /** Convert one decoded PCM frame to the ADAU's 32-bit-slot I2S format and
* hand the whole frame to the driver in a single write. One
* i2s_channel_write() call per sample (the previous approach) meant up to
* 1152 separate driver calls per MP3 frame, each with its own locking/DMA
* bookkeeping overhead — a likely source of the reported stutter/crackle,
* independent of network jitter. */
void writeFrame(i2s_chan_handle_t tx, const std::int16_t* pcm, void writeFrame(i2s_chan_handle_t tx, const std::int16_t* pcm,
int frameCount, int channels) int frameCount, int channels)
{ {
std::int32_t out[2]; // MAX_NGRAN(2) * MAX_NSAMP(576) = 1152 samples/channel, stereo => 2304.
for (int i = 0; i < frameCount; ++i) { static std::int32_t out[MAX_NGRAN * MAX_NSAMP * 2];
const int sampleCount = frameCount > MAX_NGRAN * MAX_NSAMP
? MAX_NGRAN * MAX_NSAMP
: frameCount;
for (int i = 0; i < sampleCount; ++i) {
const std::int16_t left = pcm[i * channels]; const std::int16_t left = pcm[i * channels];
const std::int16_t right = channels > 1 ? pcm[i * channels + 1] : left; const std::int16_t right = channels > 1 ? pcm[i * channels + 1] : left;
out[0] = static_cast<std::int32_t>(left) << 16; out[i * 2] = static_cast<std::int32_t>(left) << 16;
out[1] = static_cast<std::int32_t>(right) << 16; out[i * 2 + 1] = static_cast<std::int32_t>(right) << 16;
std::size_t written = 0U;
(void)i2s_channel_write(tx, out, sizeof(out), &written,
portMAX_DELAY);
} }
std::size_t written = 0U;
(void)i2s_channel_write(tx, out,
static_cast<std::size_t>(sampleCount) * 2U
* sizeof(std::int32_t),
&written, portMAX_DELAY);
} }
/** /**